-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sheet): parseValue handle number #4049
base: dev
Are you sure you want to change the base?
Conversation
View Deployment
|
Playwright test resultsDetails 19 tests across 9 suites Flaky testschromium › memory/memory.spec.ts › memory |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #4049 +/- ##
=======================================
Coverage 32.93% 32.93%
=======================================
Files 2496 2496
Lines 126832 126833 +1
Branches 28401 28402 +1
=======================================
+ Hits 41766 41767 +1
Misses 85066 85066 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add a unit test for the situation numfmt.isDate()
is true.
In this test, expect(normalizeStringByLexer('=SUM(11, 2 2, 33)')).toBe('=SUM(11, 2 2, 33)'); Execution details numfmt.parseValue('2 2') // Get { "v": 45324, "z": "m d"}
numfmt.isDate('m d') // Get true |
What's updated?
Fix parse cell input
How to test?
=SUM(11, 2 2, 33)
in the Cell=SUM(11, 2 2, 33)
(Previously it was correctly coverted to=SUM(11, 45324, 33)
)Pull Request Checklist