Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): parseValue handle number #4049

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Nov 13, 2024

What's updated?

Fix parse cell input

How to test?

  1. Enter =SUM(11, 2 2, 33) in the Cell
  2. Keep =SUM(11, 2 2, 33) (Previously it was correctly coverted to =SUM(11, 45324, 33))

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 8 seconds
commit  46b7a35
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.93%. Comparing base (6db18f3) to head (46b7a35).
Report is 39 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4049   +/-   ##
=======================================
  Coverage   32.93%   32.93%           
=======================================
  Files        2496     2496           
  Lines      126832   126833    +1     
  Branches    28401    28402    +1     
=======================================
+ Hits        41766    41767    +1     
  Misses      85066    85066           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir added the qa:untested This PR is ready to be tested label Nov 13, 2024
@Dushusir Dushusir marked this pull request as ready for review November 13, 2024 08:17
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Nov 18, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Nov 18, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a unit test for the situation numfmt.isDate() is true.

@Dushusir
Copy link
Member Author

Should add a unit test for the situation numfmt.isDate() is true.

In this test, 2 2 will be parsed as a date type

expect(normalizeStringByLexer('=SUM(11, 2 2, 33)')).toBe('=SUM(11, 2 2, 33)');

Execution details

numfmt.parseValue('2 2') // Get { "v": 45324, "z": "m d"}
numfmt.isDate('m d') // Get true

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants