Skip to content

Commit

Permalink
Prevent jittering pixels using FullViewportUpdate
Browse files Browse the repository at this point in the history
In the canvas view. The default MinimalViewportUpdate has some
inaccuracies that cause pixels to jitter in changed areas at certain
zooms and/or rotations. Updating the whole view instead is stable.

This was contributed by Meru.
  • Loading branch information
askmeaboutlo0m committed Dec 1, 2023
1 parent 46d6c7b commit 275ee01
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ Unreleased Version 2.2.0-pre
* Fix: Don't act like keep aspect ratio is checked when resizing from a selection. Thanks Meru for reporting.
* Fix: Make onion skin color partially transparent by default so that they don't turn into solid blocks on colored stuff. Thanks BulletPepper for reporting.
* Fix: Clarify the host dialog by adding additional messages that explain common sources of confusion, such as the title being required, the password being necessary to host a private session and "host on this computer" requiring port forwarding.
* Fix: Prevent jittering pixels on the canvas at certain zooms and rotations. Thanks Bluestrings, Meru and taiyu for reporting this. Also thanks Meru for actually finding the solution and contributing this fix.

2023-11-12 Version 2.2.0-beta.10
* Fix: Don't deadlock on first startup. Thanks to Hail, lowontrash, FARBOL234, Dorokinyo and hamlin for reporting.
Expand Down
1 change: 1 addition & 0 deletions src/desktop/scene/canvasview.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ CanvasView::CanvasView(QWidget *parent)
, m_blockNotices{false}
, m_hoveringOverHud{false}
{
setViewportUpdateMode(FullViewportUpdate);
viewport()->setAcceptDrops(true);
viewport()->setAttribute(Qt::WA_AcceptTouchEvents);
viewport()->setMouseTracking(true);
Expand Down

0 comments on commit 275ee01

Please sign in to comment.