Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to boolean default values not displayed #31

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

ClaPalo
Copy link
Contributor

@ClaPalo ClaPalo commented Apr 11, 2024

Fix to issue #9.
The value of the default field of a Table must be a String, but astToDiagram.js was setting a Boolean value.
I simply enforced the value to be a String by calling the toString() method.

With the fix, the default value is correctly displayed in the editor and it's correctly exported.

Copy link

vercel bot commented Apr 11, 2024

@ClaPalo is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 7:43pm

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@1ilit 1ilit merged commit 217b7e8 into drawdb-io:main Apr 11, 2024
4 checks passed
@ClaPalo ClaPalo deleted the bug-default-boolean branch April 11, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants