Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larger EFI partition, new Qt GUI option #108

Merged
merged 28 commits into from
Nov 17, 2024
Merged

Larger EFI partition, new Qt GUI option #108

merged 28 commits into from
Nov 17, 2024

Conversation

Batcastle
Copy link
Member

  • Add Qt GUI
    • This is still experimental. Bugs abound.
    • GTK GUI still exists
    • For now, Edamame defaults to the GTK GUI, need to pass --gui qt to edamame to get Qt GUI
    • In the future, Edamame will detect what GUI toolkit is in use for DE and use the same toolkit for it's GUI
  • Break Edamame into multiple packages
    • edamame-common - The common core of Edamame. The back-end.
    • edamame-gtk - The GTK GUI for Edamame
    • edamame-qt - The Qt GUI for Edamame
    • This is done so that unneeded dependencies can be removed, and have Edamame take up a smaller footprint.
    • This also allows for updates to be pushed for specific parts of Edamame independent of others.
  • Increase size of EFI partition from 500 MB to 1 GiB.

Batcastle and others added 20 commits July 30, 2024 21:12
 - Start work to support multiple UI versions, depending on UI toolkit
 - Fixed a bug where dependencies where not changing based on compilation status
This new commit adds the ability to tell Edamame to use a different GUI toolkit than normal. This is useful for testing different versions of Edamame against new GUIs without having to do too much work.
This UI still has a few major bugs, some debugging code that needs to be removed, and needs a minor UX polish. However, it is working for the most part.
Mostly marking files as execuatable
Edamame now consists of 3 packages:
 - edamame-common - The common core of all 3 packages
 - edamame-gtk - The GTK+ UI
 - edamame-qt - The Qt UI

Builds will now be placed in an auto-generated folder named `build`.
This might also help the code actually run too.
@Batcastle Batcastle added bug Something isn't working enhancement New feature or request labels Nov 16, 2024
@Batcastle Batcastle self-assigned this Nov 16, 2024
@pep8speaks
Copy link

pep8speaks commented Nov 16, 2024

Hello @Batcastle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:3: E226 missing whitespace around arithmetic operator
Line 1:6: E226 missing whitespace around arithmetic operator
Line 1:26: W292 no newline at end of file

Line 1:3: E226 missing whitespace around arithmetic operator
Line 1:6: E226 missing whitespace around arithmetic operator
Line 1:16: W292 no newline at end of file

Line 31:1: E402 module level import not at top of file

Line 28:1: E402 module level import not at top of file
Line 29:1: E402 module level import not at top of file

Line 36:1: E402 module level import not at top of file
Line 38:1: E402 module level import not at top of file
Line 39:1: E402 module level import not at top of file
Line 286:5: E303 too many blank lines (2)
Line 465:101: E501 line too long (105 > 100 characters)
Line 472:101: E501 line too long (146 > 100 characters)
Line 987:101: E501 line too long (138 > 100 characters)
Line 1057:101: E501 line too long (107 > 100 characters)
Line 1070:101: E501 line too long (115 > 100 characters)
Line 1105:101: E501 line too long (103 > 100 characters)
Line 1453:31: E128 continuation line under-indented for visual indent
Line 1819:101: E501 line too long (102 > 100 characters)
Line 1821:9: E122 continuation line missing indentation or outdented
Line 1821:101: E501 line too long (107 > 100 characters)
Line 1822:101: E501 line too long (115 > 100 characters)
Line 1834:101: E501 line too long (114 > 100 characters)
Line 1835:101: E501 line too long (140 > 100 characters)

Line 30:1: E402 module level import not at top of file
Line 31:1: E402 module level import not at top of file
Line 111:5: E303 too many blank lines (2)

Line 37:1: E402 module level import not at top of file
Line 317:9: E722 do not use bare 'except'
Line 354:9: E722 do not use bare 'except'
Line 734:1: W391 blank line at end of file

Line 34:1: E402 module level import not at top of file

Line 67:13: E126 continuation line over-indented for hanging indent
Line 72:29: E126 continuation line over-indented for hanging indent
Line 77:29: E126 continuation line over-indented for hanging indent
Line 82:29: E126 continuation line over-indented for hanging indent
Line 83:25: E126 continuation line over-indented for hanging indent
Line 89:29: E126 continuation line over-indented for hanging indent
Line 94:29: E126 continuation line over-indented for hanging indent
Line 95:25: E126 continuation line over-indented for hanging indent
Line 99:25: E126 continuation line over-indented for hanging indent
Line 101:9: E126 continuation line over-indented for hanging indent
Line 120:39: E221 multiple spaces before operator
Line 138:1: E303 too many blank lines (4)
Line 158:5: E116 unexpected indentation (comment)
Line 197:22: E225 missing whitespace around operator
Line 298:5: E303 too many blank lines (2)
Line 411:101: E501 line too long (135 > 100 characters)
Line 414:101: E501 line too long (113 > 100 characters)
Line 418:101: E501 line too long (133 > 100 characters)
Line 421:101: E501 line too long (117 > 100 characters)
Line 423:101: E501 line too long (141 > 100 characters)
Line 426:101: E501 line too long (141 > 100 characters)
Line 439:17: E722 do not use bare 'except'
Line 519:101: E501 line too long (104 > 100 characters)

Line 35:9: E116 unexpected indentation (comment)
Line 36:9: E116 unexpected indentation (comment)
Line 37:13: E116 unexpected indentation (comment)
Line 76:1: E302 expected 2 blank lines, found 1
Line 93:13: E126 continuation line over-indented for hanging indent
Line 106:9: E121 continuation line under-indented for hanging indent

Line 149:101: E501 line too long (107 > 100 characters)
Line 440:101: E501 line too long (105 > 100 characters)
Line 447:101: E501 line too long (146 > 100 characters)
Line 641:101: E501 line too long (128 > 100 characters)
Line 852:101: E501 line too long (103 > 100 characters)
Line 891:101: E501 line too long (105 > 100 characters)
Line 934:101: E501 line too long (139 > 100 characters)
Line 1000:101: E501 line too long (107 > 100 characters)
Line 1013:101: E501 line too long (115 > 100 characters)
Line 1202:20: E225 missing whitespace around operator
Line 1730:9: E122 continuation line missing indentation or outdented
Line 1730:101: E501 line too long (106 > 100 characters)
Line 1731:101: E501 line too long (110 > 100 characters)
Line 1740:101: E501 line too long (110 > 100 characters)
Line 1741:101: E501 line too long (140 > 100 characters)
Line 1791:101: E501 line too long (111 > 100 characters)
Line 1815:101: E501 line too long (105 > 100 characters)
Line 1833:101: E501 line too long (104 > 100 characters)
Line 1999:17: E117 over-indented

Line 110:5: E303 too many blank lines (2)

Line 83:101: E501 line too long (107 > 100 characters)
Line 299:9: E303 too many blank lines (2)
Line 301:9: E722 do not use bare 'except'
Line 336:9: E722 do not use bare 'except'

Line 69:101: E501 line too long (107 > 100 characters)
Line 203:5: E303 too many blank lines (2)
Line 255:9: E303 too many blank lines (2)

Line 35:9: E116 unexpected indentation (comment)
Line 36:9: E116 unexpected indentation (comment)
Line 37:13: E116 unexpected indentation (comment)
Line 76:1: E302 expected 2 blank lines, found 1
Line 93:13: E126 continuation line over-indented for hanging indent
Line 106:9: E121 continuation line under-indented for hanging indent

Line 38:1: E302 expected 2 blank lines, found 1
Line 184:13: E128 continuation line under-indented for visual indent
Line 256:59: W504 line break after binary operator

Line 30:1: E302 expected 2 blank lines, found 1
Line 33:101: E501 line too long (116 > 100 characters)

Line 38:29: E231 missing whitespace after ','
Line 44:57: W504 line break after binary operator
Line 58:58: E231 missing whitespace after ','
Line 61:58: E231 missing whitespace after ','

Comment last updated at 2024-11-17 20:07:01 UTC

@Batcastle Batcastle merged commit 6ce7254 into testing Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants