Greater Wi-Fi card support, bug fixes, massive performance increases

[Batcastle]

• Add Realtek WiFi card support
• When manually partitioning, if the user sets the boot flag on their EFI partition, do not try to reset
  • When resetting this flag, it actually UNSETS it. This can cause problems when booting on some motherboards
• Could not install on SD cards recognized as /dev/mmcblk*
  • Partitioning formatting is the same as NVMe drives, added support there.
• When not making or using a Home partition, when manually partitioning, if the user does not explicitly set this, Edamame didn't know what to do.
• Fix typo in desktop launcher
• Started to compile multiple files with Nuitka to improve performance

[pep8speaks]

Hello @Batcastle! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file usr/lib/python3/dist-packages/de_control/immersion.py:

Line 43:31: E127 continuation line over-indented for visual indent
Line 50:101: E501 line too long (175 > 100 characters)
Line 51:101: E501 line too long (145 > 100 characters)
Line 63:31: E127 continuation line over-indented for visual indent
Line 66:101: E501 line too long (164 > 100 characters)

• In the file usr/share/edamame/UI/confirm.py:

Line 30:1: E402 module level import not at top of file

• In the file usr/share/edamame/UI/error.py:

Line 28:1: E402 module level import not at top of file
Line 29:1: E402 module level import not at top of file

• In the file usr/share/edamame/UI/main.py:

Line 36:1: E402 module level import not at top of file
Line 38:1: E402 module level import not at top of file
Line 39:1: E402 module level import not at top of file
Line 286:5: E303 too many blank lines (2)
Line 465:101: E501 line too long (105 > 100 characters)
Line 472:101: E501 line too long (146 > 100 characters)
Line 987:101: E501 line too long (138 > 100 characters)
Line 1057:101: E501 line too long (107 > 100 characters)
Line 1070:101: E501 line too long (115 > 100 characters)
Line 1105:101: E501 line too long (103 > 100 characters)
Line 1453:31: E128 continuation line under-indented for visual indent
Line 1819:101: E501 line too long (102 > 100 characters)
Line 1821:9: E122 continuation line missing indentation or outdented
Line 1821:101: E501 line too long (107 > 100 characters)
Line 1822:101: E501 line too long (115 > 100 characters)
Line 1834:101: E501 line too long (114 > 100 characters)
Line 1835:101: E501 line too long (140 > 100 characters)

• In the file usr/share/edamame/UI/progress.py:

Line 30:1: E402 module level import not at top of file
Line 31:1: E402 module level import not at top of file
Line 111:5: E303 too many blank lines (2)

• In the file usr/share/edamame/UI/report.py:

Line 37:1: E402 module level import not at top of file
Line 317:9: E722 do not use bare 'except'
Line 354:9: E722 do not use bare 'except'
Line 734:1: W391 blank line at end of file

• In the file usr/share/edamame/UI/success.py:

Line 34:1: E402 module level import not at top of file

• In the file usr/share/edamame/auto_partitioner.py:

Line 67:13: E126 continuation line over-indented for hanging indent
Line 72:29: E126 continuation line over-indented for hanging indent
Line 77:29: E126 continuation line over-indented for hanging indent
Line 82:29: E126 continuation line over-indented for hanging indent
Line 83:25: E126 continuation line over-indented for hanging indent
Line 89:29: E126 continuation line over-indented for hanging indent
Line 94:29: E126 continuation line over-indented for hanging indent
Line 95:25: E126 continuation line over-indented for hanging indent
Line 99:25: E126 continuation line over-indented for hanging indent
Line 101:9: E126 continuation line over-indented for hanging indent
Line 120:39: E221 multiple spaces before operator
Line 138:1: E303 too many blank lines (4)
Line 158:5: E116 unexpected indentation (comment)
Line 197:22: E225 missing whitespace around operator
Line 298:5: E303 too many blank lines (2)
Line 411:101: E501 line too long (135 > 100 characters)
Line 414:101: E501 line too long (113 > 100 characters)
Line 418:101: E501 line too long (133 > 100 characters)
Line 421:101: E501 line too long (117 > 100 characters)
Line 423:101: E501 line too long (141 > 100 characters)
Line 426:101: E501 line too long (141 > 100 characters)
Line 439:17: E722 do not use bare 'except'
Line 519:101: E501 line too long (104 > 100 characters)

• In the file usr/share/edamame/check_internet.py:

Line 63:5: E722 do not use bare 'except'

• In the file usr/share/edamame/common.py:

Line 35:9: E116 unexpected indentation (comment)
Line 36:9: E116 unexpected indentation (comment)
Line 37:13: E116 unexpected indentation (comment)
Line 76:1: E302 expected 2 blank lines, found 1

• In the file usr/share/edamame/engine.py:

Line 51:22: E128 continuation line under-indented for visual indent
Line 59:22: E128 continuation line under-indented for visual indent
Line 61:1: E305 expected 2 blank lines after class or function definition, found 1
Line 171:30: E128 continuation line under-indented for visual indent

• In the file usr/share/edamame/installer.py:

Line 183:13: E128 continuation line under-indented for visual indent
Line 255:59: W504 line break after binary operator

• In the file usr/share/edamame/modules/auto_login_set.py:

Line 30:1: E302 expected 2 blank lines, found 1

• In the file usr/share/edamame/modules/install_extras.py:

Line 62:101: E501 line too long (105 > 100 characters)
Line 81:1: E302 expected 2 blank lines, found 1
Line 84:101: E501 line too long (119 > 100 characters)
Line 98:101: E501 line too long (104 > 100 characters)
Line 112:16: E111 indentation is not a multiple of four
Line 113:16: E111 indentation is not a multiple of four
Line 138:48: E128 continuation line under-indented for visual indent
Line 161:101: E501 line too long (121 > 100 characters)
Line 174:101: E501 line too long (120 > 100 characters)
Line 175:101: E501 line too long (108 > 100 characters)

• In the file usr/share/edamame/modules/make_swap.py:

Line 32:1: E302 expected 2 blank lines, found 1
Line 79:1: E305 expected 2 blank lines after class or function definition, found 1

• In the file usr/share/edamame/modules/master.py:

Line 149:40: E127 continuation line over-indented for visual indent
Line 150:40: E127 continuation line over-indented for visual indent
Line 151:40: E127 continuation line over-indented for visual indent
Line 155:36: E127 continuation line over-indented for visual indent
Line 156:36: E127 continuation line over-indented for visual indent
Line 157:36: E127 continuation line over-indented for visual indent
Line 205:31: E127 continuation line over-indented for visual indent
Line 224:55: E231 missing whitespace after ','
Line 291:31: E127 continuation line over-indented for visual indent
Line 295:28: E127 continuation line over-indented for visual indent
Line 299:35: E127 continuation line over-indented for visual indent
Line 305:27: E127 continuation line over-indented for visual indent
Line 324:31: E127 continuation line over-indented for visual indent
Line 353:101: E501 line too long (113 > 100 characters)
Line 365:101: E501 line too long (115 > 100 characters)
Line 380:27: E127 continuation line over-indented for visual indent
Line 388:13: E117 over-indented
Line 397:27: E127 continuation line over-indented for visual indent
Line 402:28: E127 continuation line over-indented for visual indent
Line 403:27: E127 continuation line over-indented for visual indent
Line 405:27: E127 continuation line over-indented for visual indent
Line 418:27: E127 continuation line over-indented for visual indent
Line 432:37: E127 continuation line over-indented for visual indent
Line 448:101: E501 line too long (127 > 100 characters)
Line 449:101: E501 line too long (109 > 100 characters)
Line 466:101: E501 line too long (131 > 100 characters)
Line 467:101: E501 line too long (119 > 100 characters)

• In the file usr/share/edamame/modules/set_time.py:

Line 46:1: E303 too many blank lines (3)

• In the file usr/share/edamame/modules/verify_install.py:

Line 52:28: E127 continuation line over-indented for visual indent
Line 53:28: E127 continuation line over-indented for visual indent
Line 85:9: E265 block comment should start with '# '
Line 86:9: E265 block comment should start with '# '
Line 153:101: E501 line too long (118 > 100 characters)
Line 158:36: E128 continuation line under-indented for visual indent

• In the file usr/share/edamame/oem/post_install/UI.py:

Line 36:1: E402 module level import not at top of file
Line 38:1: E402 module level import not at top of file
Line 301:32: E128 continuation line under-indented for visual indent
Line 301:32: W503 line break before binary operator
Line 418:5: E303 too many blank lines (2)
Line 471:68: E231 missing whitespace after ','
Line 500:41: E127 continuation line over-indented for visual indent

• In the file usr/share/edamame/oem/pre_install.py:

Line 36:1: E402 module level import not at top of file
Line 400:101: E501 line too long (107 > 100 characters)
Line 413:101: E501 line too long (115 > 100 characters)
Line 415:43: E711 comparison to None should be 'if cond is not None:'
Line 448:101: E501 line too long (103 > 100 characters)
Line 472:5: E303 too many blank lines (2)
Line 571:1: E303 too many blank lines (3)

• In the file usr/share/edamame/tests/test_auto_partitioner.py:

Line 30:1: E302 expected 2 blank lines, found 1
Line 33:101: E501 line too long (116 > 100 characters)

• In the file usr/share/edamame/tests/test_common.py:

Line 38:29: E231 missing whitespace after ','
Line 44:57: W504 line break after binary operator
Line 58:58: E231 missing whitespace after ','
Line 61:58: E231 missing whitespace after ','

Comment last updated at 2024-07-22 01:51:01 UTC

[SenlisO]

Is this pull request still valid, or has it been overcome by events?