Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default_is_command patch #15

Merged
merged 2 commits into from
Nov 4, 2018
Merged

default_is_command patch #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0061d6
Use consistent IS_COMMAND block in templates
vomindoraan Nov 3, 2018
11c51bb
Remove unnecessary `#undef IS_COMMAND` directives
vomindoraan Nov 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions keyboards/orthodox/keymaps/drashna/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define EE_HANDS


/* key combination for command */
#ifdef IS_COMMAND
#undef IS_COMMAND
#endif
/* key combination for magic key command */
#define IS_COMMAND() ( \
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_LALT)) \
)
Expand Down
3 changes: 1 addition & 2 deletions keyboards/s60_x/keymaps/ansi_qwertz/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@
// keymap needs oneshot functionality
#undef NO_ACTION_ONESHOT

#undef IS_COMMAND
#define IS_COMMAND() ( \
keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
)

#endif
#endif
1 change: 0 additions & 1 deletion keyboards/whitefox/keymaps/konstantin/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,4 @@
#define TAPPING_TERM 200
#define TAPPING_TOGGLE 2

#undef IS_COMMAND
#define IS_COMMAND() (keyboard_report->mods == (MOD_BIT(KC_LSFT) | MOD_BIT(KC_RCTL)))
2 changes: 1 addition & 1 deletion quantum/template/avr/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

/* key combination for magic key command */
/* defined by default. To change, uncomment and set to the combination you want */
/* defined by default; to change, uncomment and set to the combination you want */
vomindoraan marked this conversation as resolved.
Show resolved Hide resolved
// #define IS_COMMAND() (keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)))

/* control how magic key switches layers */
Expand Down
6 changes: 2 additions & 4 deletions quantum/template/ps2avrgb/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define NO_UART 1

/* key combination for magic key command */
/* defined by default. To change, uncomment and set to the combination you want */
// #define IS_COMMAND() ( \
// keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \
// )
/* defined by default; to change, uncomment and set to the combination you want */
// #define IS_COMMAND() (keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)))

/* Bootmagic Lite key configuration */
// #define BOOTMAGIC_LITE_ROW 0
Expand Down