feat: Prep for v1 #19
Conversation
src/headless_browser.ts
Outdated
| interface MessageResponse { // For when we send an event to get one back, eg running a JS expression | ||
| id: number; | ||
| result?: { | ||
| result: { [key: string]: unknown }; |
There was a problem hiding this comment.
FYI; not all responses have an "inner" result, its common but not always.
There was a problem hiding this comment.
Ok cheers, gotcha 👍 thanks !
|
OMG THE TESTS PASS |
ebebbington
added
Type: Major
|
ready for review now |
| } | ||
| } | ||
| // Connect websocket | ||
| this.socket = new WebSocket(debugUrl); |
There was a problem hiding this comment.
Wocket is a ws server right? Sinco just needs a ws client - or do you mean to use-wocket-client?
There was a problem hiding this comment.
same question i have for both of these comments... what's the best place i can read more about this?
There was a problem hiding this comment.
ill try get some info for you
|
this is cool... what's the advantage of using sockets vs sub process? |
So i heard from @caspervonb that using websockets is the better approach when connecting to headless chromium session, plus, there's a bug with sub process that essentially stops sinco from working - both reasons were why i switched to using web sockets, plus, using a sub process, we'd be running the headless browser as a repl ( |
|
Woop woop! will wait for a review from @crookse or @Guergeiro then - after that... Sinco v1 here we come 😎 |
Fixes #7
Description
Work