Overwrite #kind_of? and #is_a? in Draper::DecoratedEnumerableProxy #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized, what I wanted to do for cancan support has been done already in #72. Great work! |
steveklabnik
added a commit
that referenced
this pull request
Jan 5, 2012
Overwrite #kind_of? and #is_a? in Draper::DecoratedEnumerableProxy
|
I like it! Thank you. |
|
Thanks @steveklabnik for mergin this. I started a new pull request #110 to increase the consistency and to add is_a? to Draper::Base. It's based on the https://github.com/tmaier/draper/tree/issue-8 branch mentioned above. |
|
I merged that one in too. :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my try to fix issue #92, where draper interferes with rails'
FormHelper.I overwrote
kind_of?and its aliasis_a?to return true either whenDecoratedEnumerableProxyor@wrapped_collectionis kind of this class.As
DecoratedEnumerableProxymirrors all method calls etc. to the@wrapped_collection, this is fine for me.Overwriting of
kind_of?atDraper::Basecould be also a solution to get the cancan gem working with draper. But I have to admit, I haven't tried it yet.