replace before_filter with before_action #751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’m not sure exactly what needs to change. Here’s what another gem did to fix it: jfirebaugh/konacha#216
- require Rails 5 since Rubygems doesn’t allow us to only require activemodel-serializers-xml when Rails is version 5 - require Ruby 2.2 since that’s what Rails 5 requires
rails 5 deprecation warning was: DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from block in setup_action_controller at [..]/gems/draper-4b4f392826c4/lib/draper.rb:36)
seanlinsley
force-pushed
the
rails-5
branch
2 times, most recently
from
22a7f6d to
a7e368f
Compare
|
Hi, thanks for the PR! In #752 I've put together all the changes necessary to get Draper working with Rails 5. It would be appreciated if you could test it out in your app and report any issues you find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails 5 deprecation warning was:
DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead. (called from block in setup_action_controller at [..]/gems/draper-4b4f392826c4/lib/draper.rb:36)