Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails5 compatibility #741

Closed
wants to merge 6 commits into from
Closed

Rails5 compatibility #741

wants to merge 6 commits into from

Conversation

kbrock
Copy link

@kbrock kbrock commented May 27, 2016

Here are the changes we use locally.

They may not solve every draper issue, but they should work across all versions and I was hoping we could get this first batch in.

Thanks,

PS. this builds on some entries from #737 -- I tried to include attribution where posisble

@djberg96
Copy link

djberg96 commented Jun 1, 2016

@kbrock Not sure I understand the build failure. Was bundler just having a bad day, or does the travis.yml file need tweaking?

@DexterTheDragon
Copy link

Travis has a really old version of bundler installed by default. Adding the following to your travis.yml will probably fix it.

before_install:
  - gem update bundler

@djberg96
Copy link

djberg96 commented Jun 2, 2016

@DexterTheDragon Now we're seeing all kinds of (seemingly) unrelated errors.

@DexterTheDragon
Copy link

Looks like various errors in the test suite between all the different versions. I would bet that even the master branch doesn't pass now. If you look at the output from the last time the master branch was tested ( https://travis-ci.org/drapergem/draper/jobs/56058601 ), it was using capybara 2.4.4. Now it's using capybara 2.7.1 which probably needs a change in configuration.

@djberg96
Copy link

djberg96 commented Jun 2, 2016

@DexterTheDragon It looks like there hasn't been an update on master in over a year. Doesn't bode well.

@seanlinsley
Copy link
Member

@djberg96 I recently gained commit access to Draper, to get it working with Rails 5 🙌

@djberg96
Copy link

@seanlinsley Any updates?

@seanlinsley
Copy link
Member

In #752 I've put together all the changes necessary to get Draper working with Rails 5. It would be appreciated if everyone could test it out in their apps and report any issues you find :octocat:

@seanlinsley seanlinsley closed this Jul 9, 2016
@kbrock
Copy link
Author

kbrock commented Jul 9, 2016

thanks @seanlinsley

@kbrock kbrock deleted the rails5-compatibility branch July 9, 2016 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants