-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails5 compatibility #741
Rails5 compatibility #741
Conversation
before_filter is deprecated in Rails 5 and will be removed in Rails 5.1 Use before_action instead
@kbrock Not sure I understand the build failure. Was bundler just having a bad day, or does the travis.yml file need tweaking? |
Travis has a really old version of bundler installed by default. Adding the following to your travis.yml will probably fix it. before_install:
- gem update bundler |
@DexterTheDragon Now we're seeing all kinds of (seemingly) unrelated errors. |
Looks like various errors in the test suite between all the different versions. I would bet that even the master branch doesn't pass now. If you look at the output from the last time the master branch was tested ( https://travis-ci.org/drapergem/draper/jobs/56058601 ), it was using capybara 2.4.4. Now it's using capybara 2.7.1 which probably needs a change in configuration. |
@DexterTheDragon It looks like there hasn't been an update on master in over a year. Doesn't bode well. |
@djberg96 I recently gained commit access to Draper, to get it working with Rails 5 🙌 |
@seanlinsley Any updates? |
In #752 I've put together all the changes necessary to get Draper working with Rails 5. It would be appreciated if everyone could test it out in their apps and report any issues you find |
thanks @seanlinsley |
Here are the changes we use locally.
They may not solve every draper issue, but they should work across all versions and I was hoping we could get this first batch in.
Thanks,
PS. this builds on some entries from #737 -- I tried to include attribution where posisble