Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct some typos in Nydusify #1598

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: correct some typos in Nydusify #1598

merged 1 commit into from
Jul 9, 2024

Conversation

BruceAko
Copy link
Contributor

@BruceAko BruceAko commented Jul 9, 2024

Details

While reading the code of Nydusify, I found some typos in the comments so I fixed them.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@BruceAko BruceAko requested a review from a team as a code owner July 9, 2024 09:17
@BruceAko BruceAko requested review from jiangliu, ccx1024cc and gaius-qi and removed request for a team July 9, 2024 09:17
imeoer
imeoer approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM!

@imeoer imeoer merged commit da5d423 into dragonflyoss:master Jul 9, 2024
16 of 18 checks passed
@BruceAko BruceAko deleted the typo branch July 10, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

@jiangliu jiangliu Awaiting requested review from jiangliu jiangliu is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@ccx1024cc ccx1024cc Awaiting requested review from ccx1024cc ccx1024cc is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@gaius-qi gaius-qi Awaiting requested review from gaius-qi gaius-qi is a code owner automatically assigned from dragonflyoss/nydus-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceAko @imeoer