-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overlay: add overlay implementation #1544
Conversation
The PR is not ready for merging since it rely heavily on |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
- Coverage 61.29% 61.22% -0.08%
==========================================
Files 144 144
Lines 47035 47100 +65
Branches 44537 44602 +65
==========================================
+ Hits 28832 28838 +6
- Misses 16719 16778 +59
Partials 1484 1484
|
af3182a
to
a9c3f3f
Compare
a876b1f
to
faec9e3
Compare
Thanks for the implementation! Please also add a test case in https://github.com/dragonflyoss/nydus/tree/master/smoke/tests (maybe create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should get macOS to pass unit tests as well: https://github.com/dragonflyoss/nydus/actions/runs/7735769409/job/21091979887?pr=1544
others LGTM, thanks!
46173f5
to
a7d12c3
Compare
a7d12c3
to
9461a7c
Compare
9461a7c
to
157da95
Compare
Smoke test cases were added and passed. |
0f43960
to
8c75893
Compare
Thanks, LGTM! We can also add the doc in https://github.com/dragonflyoss/nydus/blob/master/docs/nydusd.md, may be |
b8e6050
to
cdbfa27
Compare
@imeoer docs updated to |
With help of newly introduced Overlay FileSystem in `fuse-backend-rs` library, now we can create writable rootfs in Nydus. Implementation of writable rootfs is based on one passthrough FS(as upper layer) over one readonly rafs(as lower layer). To do so, configuration is extended with some Overlay options. Signed-off-by: Wei Zhang <[email protected]>
cdbfa27
to
e2bc4bf
Compare
LGTM, thanks! |
With help of newly introduced Overlay FileSystem in
fuse-backend-rs
library, now we can create writable rootfs in Nydus. Implementation of writable rootfs is based on one passthrough FS(as upper layer) over one readonly rafs(as lower layer).To do so, configuration is extended with some Overlay options.
Details
An userspace overlay filesystem is usable for control of user data, with this implementation, Nydus can have stronger control on container rootfs.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.