Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add smoke test for nydusd hot upgrade #1533

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

loheagn
Copy link
Contributor

@loheagn loheagn commented Dec 28, 2023

Relevant Issue (if applicable)

#1421

Details

  1. add smoke test for nydusd hot upgrade
  2. rename the failover-test to takeover-test as the takeover-test contains tests for both failover and hot upgrade

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@loheagn loheagn requested review from a team as code owners December 28, 2023 12:37
@loheagn loheagn requested review from imeoer, jiangliu and changweige and removed request for a team December 28, 2023 12:37
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ecda8c) 61.27% compared to head (48fb346) 61.27%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1533   +/-   ##
=======================================
  Coverage   61.27%   61.27%           
=======================================
  Files         144      144           
  Lines       46597    46597           
  Branches    44133    44133           
=======================================
  Hits        28550    28550           
  Misses      16595    16595           
  Partials     1452     1452           

see 1 file with indirect coverage changes

smoke/tests/tool/snapshotter.go Outdated Show resolved Hide resolved
smoke/tests/tool/snapshotter.go Show resolved Hide resolved
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

smoke/tests/takeover_test.go Show resolved Hide resolved
smoke/tests/takeover_test.go Show resolved Hide resolved
smoke/tests/takeover_test.go Outdated Show resolved Hide resolved
@imeoer
Copy link
Collaborator

imeoer commented Dec 29, 2023

@loheagn Can we also give a doc to explain how the failover & hot upgrade work and give the usage? For example docs/nydus-failover-upgrade.md, Thanks!

@loheagn
Copy link
Contributor Author

loheagn commented Dec 29, 2023

@loheagn Can we also give a doc to explain how the failover & hot upgrade work and give the usage? For example docs/nydus-failover-upgrade.md, Thanks!

@imeoer Thanks for the review! All comments are fixed. I will submit another PR to add the doc.

@Desiki-high
Copy link
Member

@loheagn Please user rebase to update branch not Merge branch 'master'.

@loheagn
Copy link
Contributor Author

loheagn commented Jan 2, 2024

@loheagn Please user rebase to update branch not Merge branch 'master'.

fixed

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imeoer imeoer merged commit 04b4552 into dragonflyoss:master Jan 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants