Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nydusify: fix unit test fail #1530

Merged
merged 3 commits into from
Dec 25, 2023
Merged

nydusify: fix unit test fail #1530

merged 3 commits into from
Dec 25, 2023

Commits on Dec 25, 2023

  1. nydusify: fix unit test fail in utils 

    utils_test.go:248:
                Error Trace:    /root/nydus/contrib/nydusify/pkg/utils/utils_test.go:248
                Error:          Should be true
                Test:           TestRetryWithHTTP

Signed-off-by: Yadong Ding <[email protected]>
    @Desiki-high
    Desiki-high committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    fab8a6f View commit details
    Browse the repository at this point in the history

  2. action: delete useless env 

    Signed-off-by: Yadong Ding <[email protected]>
    @Desiki-high
    Desiki-high committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    8d2f0e9 View commit details
    Browse the repository at this point in the history

  3. nydusify: fix error in go vet 

    `sudo` in action will change go env, remove sudo.
In runner user, we can create file in unpacktargz-test inseted of temp/unpacktargz-test,
so don't use os.CreateTemp in archive_test.go.

Signed-off-by: Yadong Ding <[email protected]>
    @Desiki-high
    Desiki-high committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    bd02185 View commit details
    Browse the repository at this point in the history