Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: use same golang cache #1501

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Dec 1, 2023

Relevant Issue (if applicable)

N/A

Details

setup-go@v4 uses the cache name of setup-go-Linux-ubuntu22-go-1.20.11-${hash}. actions/cache@v3 restores the same content, so just restore the same cache.
image
image
After changes, nydus-integration-test will restore the same cache.
image

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

setup-go@v4 use cache name `setup-go-Linux-ubuntu22-go-1.20.11-${hash}`.
`actions/cache@v3` restore the same content, so just restore the same cache.

Signed-off-by: Yadong Ding <[email protected]>
@Desiki-high Desiki-high requested a review from a team as a code owner December 1, 2023 02:23
@Desiki-high Desiki-high requested review from bergwolf, jiangliu and hsiangkao and removed request for a team December 1, 2023 02:23
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #1501 (3256488) into master (a1ad70a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   62.75%   62.74%   -0.01%     
==========================================
  Files         123      123              
  Lines       43340    43340              
  Branches    43340    43340              
==========================================
- Hits        27199    27195       -4     
- Misses      14827    14831       +4     
  Partials     1314     1314              

see 1 file with indirect coverage changes

@imeoer imeoer merged commit f1de095 into dragonflyoss:master Dec 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants