Introduce sqlite database to store state information for CAS #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangliu
requested review from
bergwolf,
liubin and
gaius-qi
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
+ Coverage 62.76% 62.77% +0.01%
==========================================
Files 123 125 +2
Lines 43340 43599 +259
Branches 43340 43599 +259
==========================================
+ Hits 27202 27371 +169
- Misses 14827 14873 +46
- Partials 1311 1355 +44
|
jiangliu
force-pushed
the
cas-db
branch
5 times, most recently
from
5b46804
to
7b490c4
Compare
|
Simplified version of #1399, to support deduplication at runtime instead of build time. |
jiangliu
force-pushed
the
cas-db
branch
5 times, most recently
from
08b0d16
to
95c7832
Compare
imeoer
reviewed
Nov 30, 2023
ccx1024cc
suggested changes
Dec 1, 2023
ccx1024cc
suggested changes
Dec 1, 2023
jiangliu
force-pushed
the
cas-db
branch
2 times, most recently
from
465e31e
to
b8fc335
Compare
Introduce sqlite to store CAS related information. Signed-off-by: Huang Jianan <[email protected]> Signed-off-by: xwb1136021767 <[email protected]>
Refine the sqlite database structure for storing CAS information. Signed-off-by: Jiang Liu <[email protected]>
Move cas db from util into storage. Signed-off-by: Jiang Liu <[email protected]>
Sqlite connection is not thread safe, so use connection pool to support multi-threading. Signed-off-by: Jiang Liu <[email protected]>
Since this mod is basic module, which has no entry from user, smoke test is not required. |
|
LGTM |
imeoer
approved these changes
Dec 6, 2023
ccx1024cc
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
We are going to support runtime chunk deduplication, and this PR introduce sqlite database to store chunk state information for deduplication.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.