-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go work: support go workspace mode and sync deps #1464
Conversation
6fec665
to
a75812e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
- Coverage 44.37% 44.37% -0.01%
==========================================
Files 123 123
Lines 38896 38896
Branches 38896 38896
==========================================
- Hits 17261 17259 -2
- Misses 20695 20696 +1
- Partials 940 941 +1 |
a75812e
to
2331b50
Compare
We have mutile golang modules in repo, golang had supported the workspaces, see https://go.dev/blog/get-familiar-with-workspaces. Use `go work sync` to synchronize versions of the same dependencies for different modules. Signed-off-by: Yadong Ding <[email protected]>
377dafe
to
d27f12e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, thanks!
cc @imeoer and @ccx1024cc, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
We have multiple Golang modules in the repo and Golang has supported the workspaces, see https://go.dev/blog/get-familiar-with-workspaces. I think
go work
can help to develop this repo in the future.Details
go work
to manage multiple Golang modules.go work sync
to synchronize versions of the same dependencies for different modules.Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.