-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/v2.2 parse image pull auth from env #1383
Backport/v2.2 parse image pull auth from env #1383
Conversation
@sctb512 , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/86904 |
@sctb512 , The CI test is completed, please check result:
Congratulations, your test job passed! |
146b97b
to
d519e97
Compare
@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87145 |
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
Signed-off-by: Bin Tang <[email protected]>
d519e97
to
45ee936
Compare
@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87151 |
@sctb512 , The CI test is completed, please check result:
Congratulations, your test job passed! |
@sctb512 , The CI test is completed, please check result:
Congratulations, your test job passed! |
Details
This commit attempts to avoid loading auth from the nydusd configuration file, which is insecure for users. The auth loaded from env will overwrite the auth loaded from file if it is not null.
Related to #1382
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.