Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydus-image: add unit test for setting default compression algorithm #1354

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

xwb1136021767
Copy link
Contributor

Relevant Issue (if applicable)

Add unit test for da501f7.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@xwb1136021767 xwb1136021767 requested a review from a team as a code owner July 6, 2023 10:53
@xwb1136021767 xwb1136021767 requested review from bergwolf, jiangliu and changweige and removed request for a team July 6, 2023 10:53
@anolis-bot
Copy link
Collaborator

@xwb1136021767 , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/83209

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1354 (94db6de) into master (98834dd) will increase coverage by 0.14%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
+ Coverage   45.80%   45.94%   +0.14%     
==========================================
  Files         122      122              
  Lines       37733    37766      +33     
  Branches    37733    37766      +33     
==========================================
+ Hits        17284    17353      +69     
+ Misses      19538    19501      -37     
- Partials      911      912       +1     
Impacted Files Coverage Δ
builder/src/core/blob.rs 25.29% <94.44%> (+11.66%) ⬆️

... and 3 files with indirect coverage changes

@anolis-bot
Copy link
Collaborator

@xwb1136021767 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu merged commit 0c225ca into dragonflyoss:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants