Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: add read-amount and read-count for benchmark #1243

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

Desiki-high
Copy link
Member

We should add the read-amount and read-count for nydus benchmark to compare nydus, zran with different batchsize, config and so on.

For oci benchmark we use "-" for these fields.

@Desiki-high Desiki-high requested a review from a team as a code owner April 22, 2023 08:54
@Desiki-high Desiki-high requested review from bergwolf, luodw and hsiangkao and removed request for a team April 22, 2023 08:54
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #1243 (2551c4b) into master (27fa973) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1243   +/-   ##
=======================================
  Coverage   45.01%   45.01%           
=======================================
  Files         126      126           
  Lines       37382    37382           
  Branches    37382    37382           
=======================================
  Hits        16828    16828           
  Misses      19667    19667           
  Partials      887      887           

see 1 file with indirect coverage changes

@Desiki-high
Copy link
Member Author

Desiki-high commented Apr 22, 2023

cargo-deny has fixed by #1240.

@Desiki-high Desiki-high changed the title [WIP]action: add read-amount and read-count for benchmark action: add read-amount and read-count for benchmark Apr 22, 2023
@anolis-bot
Copy link
Collaborator

@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69428

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@Desiki-high Desiki-high requested a review from imeoer April 22, 2023 11:03
We should add the read-amount and read-count for nydus benchmark to
compare nydus and zran or different batchsize.

Signed-off-by: Desiki-high <[email protected]>
@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/69509

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Desiki-high Desiki-high merged commit 05fff6e into dragonflyoss:master Apr 23, 2023
@Desiki-high Desiki-high deleted the benchmark-metrics branch April 23, 2023 02:40
@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
nydus_ci❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants