nydus-image: support small chunks mergence #1202
Conversation
hangvane
requested review from
liubin,
changweige and
adamqqqplay
and removed request for
a team
hangvane
changed the title
|
/retest |
|
@hangvane , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/64962 |
|
Thanks for your contribution! Maybe you could squash these commits? |
|
@hangvane , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@hangvane , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/64990 |
|
@hangvane , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@hangvane , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/65282 |
|
@hangvane , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
@adamqqqplay Thanks for your advice! Would you please explain why squashing commits is needed? I'm a beginner of github, and I'm afraid of messing up this PR by mistake. |
|
@hangvane , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/65304 |
|
@jiangliu A problem about runtime decompressing is considering. Please do not merge this PR at this time. I'll add more benchmark cases for discussion. |
|
@hangvane , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/68263 |
|
@hangvane , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/68281 |
Check `zran` flag before set `zran` values. Refine comments. Signed-off-by: Wenhao Ren <[email protected]>
Refactor `Node::dump_file_chunk()` to reuse data compress and write procedure. Signed-off-by: Wenhao Ren <[email protected]>
Enhance chunk info to support batch chunk. Introduce BatchInflateContext and generator. Signed-off-by: Wenhao Ren <[email protected]>
Add `--batch-size` subcommand on nydus-image. Add build time support of batch chunk. Signed-off-by: Wenhao Ren <[email protected]>
|
@hangvane , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/68393 |
|
@hangvane , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
According to the test result, how about the default configuration of:
|
@jiangliu The basic idea is that, As for |
It would be better to avoid introducing configuration for |
Add the support of merging small file chunks into one batch chunk, for
ConversionType::DirectoryToRafs,ConversionType::EStargzToRafs,ConversionType::TargzToRafs, andConversionType::TarToRafs.basic usage
Add the
--batch-sizearg to command to enable chunk mergence for supported conversion types:benchmarks
This PR is related to #884, #885, dragonflyoss/Dragonfly2#1858