Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: Add a README.md to nydus-service #1121

Merged
merged 2 commits into from
Mar 26, 2023
Merged

service: Add a README.md to nydus-service #1121

merged 2 commits into from
Mar 26, 2023

Conversation

taoohong
Copy link
Contributor

@taoohong taoohong commented Mar 1, 2023

Add a README.md to nydus-service crate.

@taoohong taoohong requested a review from a team as a code owner March 1, 2023 05:48
@taoohong taoohong requested review from imeoer, changweige and hsiangkao and removed request for a team March 1, 2023 05:48
@anolis-bot
Copy link
Collaborator

@taoohong , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/53617

@anolis-bot
Copy link
Collaborator

@taoohong , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

imeoer
imeoer reviewed Mar 1, 2023
View reviewed changes
service/README.md Outdated Show resolved Hide resolved
service/README.md
@@ -0,0 +1,157 @@
# nydus-service
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we put a link to reference it in README.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a part named "Reuse Nydus Services" in README.md to put this link.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, and give a brief description.

@jiangliu
Copy link
Collaborator

jiangliu commented Mar 1, 2023

Let's delay this PR to v2.3?

@anolis-bot
Copy link
Collaborator

@taoohong , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/53696

@taoohong
Copy link
Contributor Author

taoohong commented Mar 1, 2023

Let's delay this PR to v2.3?

Ok. that's fine.

@anolis-bot
Copy link
Collaborator

@taoohong , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

jiangliu
jiangliu reviewed Mar 1, 2023
View reviewed changes
service/README.md
"enable": true,
"threads_count": 4
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help to update config_v2 format?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/dragonflyoss/image-service/blob/master/docs/samples/configuration_v2.toml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd like to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taoohong Hi, have you solved this problem?

ccx1024cc
ccx1024cc reviewed Mar 23, 2023
View reviewed changes
Copy link
Contributor

@ccx1024cc ccx1024cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also backport to stable/v2.2. Thanks ~~~~

@taoohong
Copy link
Contributor Author

Please also backport to stable/v2.2. Thanks ~~~~

Ok

@anolis-bot
Copy link
Collaborator

@taoohong , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/59247

@anolis-bot
Copy link
Collaborator

@taoohong , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu merged commit 7e3baee into dragonflyoss:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamqqqplay adamqqqplay adamqqqplay left review comments

@ccx1024cc ccx1024cc ccx1024cc left review comments

@imeoer imeoer imeoer left review comments

@jiangliu jiangliu jiangliu approved these changes

@changweige changweige Awaiting requested review from changweige changweige is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@hsiangkao hsiangkao Awaiting requested review from hsiangkao hsiangkao is a code owner automatically assigned from dragonflyoss/nydus-reviewers

Assignees
No one assigned
Labels
anolis_test_pass backport/v2.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@taoohong @anolis-bot @jiangliu @imeoer @ccx1024cc @adamqqqplay