Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Github Actions fails on master branch #1301

Closed
adamqqqplay opened this issue May 25, 2023 · 0 comments
Closed

Two Github Actions fails on master branch #1301

adamqqqplay opened this issue May 25, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@adamqqqplay
Copy link
Member

Additional Information

The following information is very important in order to help us to help you. Omission of the following details may delay your support request or receive no attention at all.

Details about issue

1. Action: Convert & Check Images

Convert & Check Images fails since May 23, 2023, bug probably introduced by #1257.
Nydusify check reported this error: https://github.com/dragonflyoss/image-service/actions/runs/5063307750/jobs/9089815587

time="2023-05-24T00:25:47Z" level=info msg="Verified Nydus image localhost:5000/alpine:nydus-nightly-v6"
<E> erofs: corrupted `..' dirent @ nid 128, lblk 0, index 1
<E> erofs: Found some filesystem corruption

It may be necessary to make changes in nydusify or nydus-image, and maintain compatibility with older versions.

2. Action: Release

Release fails since May 23, 2023, bug probably introduced by #1257.
Cargo build reported this error: https://github.com/dragonflyoss/image-service/actions/runs/5062514078/jobs/9088121838

error[E0308]: mismatched types
   --> rafs/src/builder/stargz.rs:[24](https://github.com/dragonflyoss/image-service/actions/runs/5062514078/jobs/9088121838#step:4:25)9:21
    |
249 |         self.mode & !libc::S_IFMT | mode as u32
    |                     ^^^^^^^^^^^^^ expected `u32`, found `u16`

error[E0277]: no implementation for `u32 & u16`
   --> rafs/src/builder/stargz.rs:249:19
    |
249 |         self.mode & !libc::S_IFMT | mode as u32
    |                   ^ no implementation for `u32 & u16`
    |
    = help: the trait `BitAnd<u16>` is not implemented for `u[32](https://github.com/dragonflyoss/image-service/actions/runs/5062514078/jobs/9088121838#step:4:33)`
    = help: the following other types implement trait `BitAnd<Rhs>`:
              <&'a u32 as BitAnd<u32>>
              <&u32 as BitAnd<&u32>>
              <u32 as BitAnd<&u32>>
              <u32 as BitAnd>

It may be necessary to do some processing for compilation on macos.

@adamqqqplay adamqqqplay added the bug Something isn't working label May 25, 2023
jiangliu added a commit to jiangliu/image-service that referenced this issue May 27, 2023
The `nid` is not actually used yet, but we should still generate it
with correct value.

Fixes: dragonflyoss#1301

Signed-off-by: Jiang Liu <[email protected]>
@imeoer imeoer closed this as completed in 92e6340 May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant