Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from k8s.gcr.io to registry.k8s.io #2186

Merged
merged 1 commit into from
Mar 16, 2023
Merged

chore: migrate from k8s.gcr.io to registry.k8s.io #2186

merged 1 commit into from
Mar 16, 2023

Conversation

ahmedwaleedmalik
Copy link
Contributor

Description

Kubernetes is migrating its image registry from [k8s.gcr.io](http://k8s.gcr.io/) to [registry.k8s.io](http://registry.k8s.io/).

Part of kubernetes/k8s.io#4780.

It's just changing some testing/fixture data so it's a benign change but I made it anyways.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ahmedwaleedmalik ahmedwaleedmalik requested a review from a team as a code owner March 16, 2023 06:47
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #2186 (c765bf7) into main (d1388ff) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2186      +/-   ##
==========================================
+ Coverage   48.24%   48.25%   +0.01%     
==========================================
  Files         141      141              
  Lines       19668    19668              
==========================================
+ Hits         9489     9491       +2     
  Misses       9591     9591              
+ Partials      588      586       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 48.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit b72da1d into dragonflyoss:main Mar 16, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the update-k8s-registry branch March 16, 2023 07:25
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants