Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add default build param GOOS GOARCH #2155

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

garenwen
Copy link
Contributor

@garenwen garenwen commented Mar 12, 2023

Description

  • add default build param GOOS GOARCH

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Change-Id: I518b41e71e22b699db3c34c378c79a8237ca6fb0
@garenwen garenwen requested a review from a team as a code owner March 12, 2023 09:10
@garenwen garenwen linked an issue Mar 12, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #2155 (94a12cc) into main (5d5804e) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2155      +/-   ##
==========================================
+ Coverage   47.93%   48.00%   +0.06%     
==========================================
  Files         141      141              
  Lines       19640    19640              
==========================================
+ Hits         9415     9428      +13     
+ Misses       9634     9620      -14     
- Partials      591      592       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 48.00% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garenwen garenwen requested a review from jim3ma March 16, 2023 06:55
@gaius-qi gaius-qi merged commit f53cc8d into main Mar 16, 2023
@gaius-qi gaius-qi deleted the feat/specify-build-parameters branch March 16, 2023 06:55
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The build environment is arm64, but I want to build amd64
3 participants