Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preheat tack id #1375

Merged
merged 3 commits into from
Jun 13, 2022
Merged

fix: preheat tack id #1375

merged 3 commits into from
Jun 13, 2022

Conversation

gaius-qi
Copy link
Member

Description

  • Remove default digest value.
  • Add end time to seed piece.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 13, 2022
@gaius-qi gaius-qi self-assigned this Jun 13, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 13, 2022 09:06
@gaius-qi gaius-qi linked an issue Jun 13, 2022 that may be closed by this pull request
Preheat successful, but does not appear to be working properly #1367
Closed
@gaius-qi
feat: preheat
f15f682 
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi merged commit 95c105a into main Jun 13, 2022
@gaius-qi gaius-qi deleted the feature/preheat branch June 13, 2022 12:43
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
fix: preheat tack id (#1375)
2362a67 
* fix: preheat with task id

Signed-off-by: Gaius <[email protected]>

* fix: add end time to seed piece

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero yxxhero approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@1037husterljx 1037husterljx Awaiting requested review from 1037husterljx 1037husterljx is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@cndoit18 cndoit18 Awaiting requested review from cndoit18 cndoit18 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
client manager
Projects
None yet
Milestone
v2.0.4
Development

Successfully merging this pull request may close these issues.

Preheat successful, but does not appear to be working properly
2 participants
@gaius-qi @yxxhero