Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scheduler register interface return task type #1318

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Scheduler register interface return task type.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.3 milestone May 20, 2022
@gaius-qi gaius-qi self-assigned this May 20, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner May 20, 2022 03:35
@gaius-qi gaius-qi force-pushed the feature/task-type branch from b1ef9bf to c25234f Compare May 20, 2022 03:43
@gaius-qi gaius-qi force-pushed the feature/task-type branch from c25234f to 2c2cc7d Compare May 20, 2022 04:24
@codecov-commenter
Copy link

Codecov Report

Merging #1318 (2c2cc7d) into main (4875d68) will decrease coverage by 0.23%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
- Coverage   45.71%   45.47%   -0.24%     
==========================================
  Files         140      140              
  Lines       11890    11887       -3     
==========================================
- Hits         5435     5406      -29     
- Misses       5841     5871      +30     
+ Partials      614      610       -4     
Flag Coverage Δ
e2etests ?
unittests 45.47% <85.71%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/peer.go 77.55% <ø> (ø)
scheduler/service/service.go 82.88% <85.71%> (+0.04%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️
client/daemon/rpcserver/seeder.go 56.88% <0.00%> (-4.80%) ⬇️
client/daemon/peer/piece_manager.go 52.61% <0.00%> (-0.02%) ⬇️
client/daemon/storage/local_storage.go 28.08% <0.00%> (+0.04%) ⬆️
client/daemon/peer/peertask_conductor.go 57.27% <0.00%> (+0.12%) ⬆️
client/daemon/storage/local_storage_subtask.go 27.72% <0.00%> (+0.33%) ⬆️

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit f9bb8ba into main May 20, 2022
@gaius-qi gaius-qi deleted the feature/task-type branch May 20, 2022 07:05
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants