Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dfcache rpm/deb packages and man pages and publish in goreleaser #1259

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

eryugey
Copy link
Contributor

@eryugey eryugey commented Apr 18, 2022

Note that dfcache*.md files are generated by dfcache doc command.

Signed-off-by: Eryu Guan [email protected]

Description

add dfcache rpm/deb packages and man pages

Related Issue

#1252

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@eryugey eryugey requested a review from a team as a code owner April 18, 2022 04:42
@eryugey eryugey mentioned this pull request Apr 18, 2022
@eryugey eryugey changed the title feat: add dfcache command and man pages to dfget rpm/deb packages feat: add dfcache rpm/deb packages and man pages Apr 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1259 (2f1b50d) into main (96bdf9f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
+ Coverage   46.11%   46.13%   +0.01%     
==========================================
  Files         135      135              
  Lines       11245    11245              
==========================================
+ Hits         5186     5188       +2     
+ Misses       5486     5483       -3     
- Partials      573      574       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.13% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_conductor.go 57.93% <0.00%> (-0.22%) ⬇️
cdn/supervisor/progress/progress.go 96.87% <0.00%> (+6.25%) ⬆️

eryugey added 2 commits April 18, 2022 13:19
Note that dfcache*.md files are generated by `dfcache doc` command.

Signed-off-by: Eryu Guan <[email protected]>
@eryugey eryugey changed the title feat: add dfcache rpm/deb packages and man pages feat: add dfcache rpm/deb packages and man pages and publish in goreleaser Apr 18, 2022
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 3582336 into dragonflyoss:main Apr 18, 2022
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
…easer (#1259)

add goreleaser dfcache rpm/deb packages and man pages

Note that dfcache*.md files are generated by `dfcache doc` command.

Signed-off-by: Eryu Guan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants