Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rpc cdn sync piece tasks #1168

Merged
merged 3 commits into from
Mar 18, 2022
Merged

fix: rpc cdn sync piece tasks #1168

merged 3 commits into from
Mar 18, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Mar 18, 2022

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner March 18, 2022 02:56
gaius-qi
gaius-qi previously approved these changes Mar 18, 2022
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #1168 (c8876c8) into main (57aabb2) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
- Coverage   46.19%   46.12%   -0.07%     
==========================================
  Files         132      132              
  Lines       10239    10239              
==========================================
- Hits         4730     4723       -7     
- Misses       4961     4968       +7     
  Partials      548      548              
Flag Coverage Δ
unittests 46.12% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdn/supervisor/progress/progress.go 90.62% <0.00%> (-6.25%) ⬇️
client/daemon/peer/peertask_conductor.go 57.00% <0.00%> (-0.36%) ⬇️

@jim3ma jim3ma changed the title fxi: rpc cdn sync piece tasks fix: rpc cdn sync piece tasks Mar 18, 2022
@jim3ma jim3ma force-pushed the fix/rpc-cdn-sync-piece-tasks branch from dd01c99 to d6fdf7b Compare March 18, 2022 03:13
@yxxhero yxxhero requested a review from gaius-qi March 18, 2022 03:16
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit a27450c into main Mar 18, 2022
@jim3ma jim3ma deleted the fix/rpc-cdn-sync-piece-tasks branch March 18, 2022 06:23
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants