Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scheduler piece cost time #1118

Merged
merged 2 commits into from
Mar 3, 2022
Merged

fix: scheduler piece cost time #1118

merged 2 commits into from
Mar 3, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Mar 3, 2022

Signed-off-by: Gaius [email protected]

Description

  • Fix scheduler piece cost time.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 3, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 3, 2022 06:36
@gaius-qi gaius-qi self-assigned this Mar 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1118 (b343d1a) into main (d7ab722) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   45.93%   45.91%   -0.02%     
==========================================
  Files         130      130              
  Lines        9983     9985       +2     
==========================================
- Hits         4586     4585       -1     
- Misses       4877     4880       +3     
  Partials      520      520              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.91% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/timeutils/time_utils.go 66.66% <100.00%> (+5.12%) ⬆️
scheduler/service/service.go 87.19% <100.00%> (ø)
cdn/supervisor/progress/progress.go 91.04% <0.00%> (-5.98%) ⬇️
client/daemon/peer/piece_broker.go 88.88% <0.00%> (+3.70%) ⬆️

jim3ma
jim3ma previously approved these changes Mar 3, 2022
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit d1b8ee6 into main Mar 3, 2022
@gaius-qi gaius-qi deleted the feature/cost branch March 3, 2022 07:18
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants