Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when peer state is PeerStateSucceeded, return size scope is small #1103

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • When peer state is PeerStateSucceeded, return size scope is small.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Feb 28, 2022
@gaius-qi gaius-qi self-assigned this Feb 28, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner February 28, 2022 08:30
@codecov-commenter
Copy link

Codecov Report

Merging #1103 (c3a17aa) into main (adeb471) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   45.42%   45.44%   +0.01%     
==========================================
  Files         130      130              
  Lines        9919     9929      +10     
==========================================
+ Hits         4506     4512       +6     
- Misses       4888     4891       +3     
- Partials      525      526       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.44% <60.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/service/service.go 87.22% <60.00%> (-0.88%) ⬇️

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit e78232d into main Feb 28, 2022
@gaius-qi gaius-qi deleted the feature/small-peer branch February 28, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants