-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge ranged request storage into parent #1078
Merged
gaius-qi
merged 21 commits into
main
from
feat/merge-ranged-request-storage-into-parent
Feb 23, 2022
Merged
feat: merge ranged request storage into parent #1078
gaius-qi
merged 21 commits into
main
from
feat/merge-ranged-request-storage-into-parent
Feb 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1078 +/- ##
==========================================
- Coverage 45.83% 45.31% -0.52%
==========================================
Files 129 130 +1
Lines 9543 9904 +361
==========================================
+ Hits 4374 4488 +114
- Misses 4675 4891 +216
- Partials 494 525 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
jim3ma
force-pushed
the
feat/merge-ranged-request-storage-into-parent
branch
from
February 17, 2022 09:36
caffc12
to
6db9418
Compare
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
…uest-storage-into-parent
Signed-off-by: Jim Ma <[email protected]>
…bled Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
244372610
approved these changes
Feb 23, 2022
gaius-qi
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Implement for #1050 |
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
* feat: merge ranged request storage into parent Signed-off-by: Jim Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Ma [email protected]
Description
In previous prefetch PR #1503, ranged request and parent request are split into 2 peer task and 2 storage cache.
In this PR, we merge them into only one storage cache.
With this feature, we can support nydusd to invoke daemon grpc to download partial blobs with final target path.
nydusd
did not need to save network data info file. The underlay file is only one copy via sharing inode in same filesystem.Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: