This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
[feature]: add generate doc cmd for supernode #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
- Coverage 47.28% 47.25% -0.03%
==========================================
Files 118 116 -2
Lines 7244 7203 -41
==========================================
- Hits 3425 3404 -21
+ Misses 3549 3532 -17
+ Partials 270 267 -3
Continue to review full report at Codecov.
|
cmd/supernode/app/gen_doc.go
Outdated
| @@ -36,7 +36,7 @@ func init() { | |||
| genDocCommand := &GenDocCommand{} | |||
| genDocCommand.cmd = &cobra.Command{ | |||
| Use: "gen-doc", | |||
| Short: "Generate Document for dfget command line tool with MarkDown format", | |||
| Short: "Generate Document for supernode command line tool with MarkDown format", | |||
There was a problem hiding this comment.
with MarkDown format I think with isn't appropriate,in can be better?
pkg/cmd/gen_doc.go
Outdated
| genDocCommand := &GenDocCommand{} | ||
| genDocCommand.cmd = &cobra.Command{ | ||
| Use: "gen-doc", | ||
| Short: "Generate Document for dfdaemon command line tool with MarkDown format", | ||
| Short: fmt.Sprintf("Generate Document for %s command line tool with MarkDown format", name), |
Signed-off-by: Starnop <[email protected]>
starnop
force-pushed
the
supernode-cli-docs
branch
from
d32e824 to
c7ae59b
Compare
|
|
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
[feature]: add generate doc cmd for supernode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1097
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews