Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfget supports HDFS #838

Merged
merged 2 commits into from
Nov 19, 2024
Merged

dfget supports HDFS #838

merged 2 commits into from
Nov 19, 2024

Conversation

BruceAko
Copy link
Contributor

@BruceAko BruceAko commented Nov 12, 2024

Description

Support dfget hdfs://example/config -O output to download HDFS object and support directory recursive downloading.

Related Issue

close #500

Motivation and Context

Dragonfly rust client does not support back-to-source downloading of different object storage protocols. Need to support HDFS protocol in dragonfly-client-backend crate, implemented based on trait Backend and it needs to support directory recursive downloading.

Screenshot

1731590787352
1731590828231
1731590861823

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 20.10870% with 147 lines in your changes missing coverage. Please review.

Project coverage is 32.62%. Comparing base (6ce4297) to head (1360896).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client-backend/src/hdfs.rs 15.71% 118 Missing ⚠️
dragonfly-client/src/bin/dfget/main.rs 7.69% 24 Missing ⚠️
dragonfly-client/src/resource/task.rs 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   32.89%   32.62%   -0.27%     
==========================================
  Files          56       57       +1     
  Lines        8515     8686     +171     
==========================================
+ Hits         2801     2834      +33     
- Misses       5714     5852     +138     
Files with missing lines Coverage Δ
dragonfly-client-backend/src/http.rs 96.94% <100.00%> (+0.09%) ⬆️
dragonfly-client-backend/src/lib.rs 98.37% <100.00%> (+0.02%) ⬆️
dragonfly-client-backend/src/object_storage.rs 84.25% <ø> (ø)
dragonfly-client/src/resource/piece.rs 50.74% <ø> (ø)
dragonfly-client/src/resource/task.rs 0.00% <0.00%> (ø)
dragonfly-client/src/bin/dfget/main.rs 26.31% <7.69%> (-0.57%) ⬇️
dragonfly-client-backend/src/hdfs.rs 15.71% <15.71%> (ø)
---- 🚨 Try these New Features:

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@BruceAko BruceAko changed the title [WIP] dfget supports HDFS dfget supports HDFS Nov 14, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 8ce9f23 into dragonflyoss:main Nov 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dfget support HDFS protocol and supports directory recursive downloading
2 participants