-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dfget supports HDFS #838
Merged
Merged
dfget supports HDFS #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceAko
force-pushed
the
main
branch
9 times, most recently
from
November 12, 2024 16:24
e7d94dd
to
d248894
Compare
BruceAko
force-pushed
the
main
branch
4 times, most recently
from
November 13, 2024 14:42
821db89
to
bee6bda
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
==========================================
- Coverage 32.89% 32.62% -0.27%
==========================================
Files 56 57 +1
Lines 8515 8686 +171
==========================================
+ Hits 2801 2834 +33
- Misses 5714 5852 +138
|
gaius-qi
requested changes
Nov 14, 2024
BruceAko
force-pushed
the
main
branch
3 times, most recently
from
November 14, 2024 10:13
76ba8ae
to
4a29c6b
Compare
BruceAko
force-pushed
the
main
branch
4 times, most recently
from
November 14, 2024 11:29
6ad0315
to
8e42e6f
Compare
BruceAko
force-pushed
the
main
branch
4 times, most recently
from
November 14, 2024 12:40
492ea50
to
8104c02
Compare
BruceAko
force-pushed
the
main
branch
11 times, most recently
from
November 14, 2024 13:56
0987c95
to
032a0e6
Compare
gaius-qi
requested changes
Nov 18, 2024
BruceAko
force-pushed
the
main
branch
4 times, most recently
from
November 19, 2024 02:18
10dca56
to
51feaf2
Compare
Signed-off-by: BruceAko <[email protected]>
Signed-off-by: BruceAko <[email protected]>
gaius-qi
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support
dfget hdfs://example/config -O output
to download HDFS object and support directory recursive downloading.Related Issue
close #500
Motivation and Context
Dragonfly rust client does not support back-to-source downloading of different object storage protocols. Need to support HDFS protocol in
dragonfly-client-backend
crate, implemented based ontrait Backend
and it needs to support directory recursive downloading.Screenshot