Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

bugfix: reduce error logs when download home dir not exist #960

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

starnop
Copy link
Contributor

@starnop starnop commented Sep 24, 2019

…me dir not exist

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

At present, gc disk will produce error logs continuously when download home dir not exist. And in this case, there is no need to do the gc job. So just return directly in this PR.

Ⅱ. Does this pull request fix one issue?

NONE.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/log kind/bug This is bug report for project size/S labels Sep 24, 2019
@starnop starnop requested review from lowzj and yeya24 September 24, 2019 07:25
@codecov-io
Copy link

Codecov Report

Merging #960 into master will decrease coverage by 0.04%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
- Coverage   46.46%   46.42%   -0.05%     
==========================================
  Files         116      116              
  Lines        6910     6910              
==========================================
- Hits         3211     3208       -3     
- Misses       3441     3445       +4     
+ Partials      258      257       -1
Impacted Files Coverage Δ
supernode/daemon/mgr/cdn/cdn_gc.go 0% <0%> (ø) ⬆️
supernode/daemon/mgr/cdn/cache_detector.go 7.24% <0%> (ø) ⬆️
supernode/store/local_storage.go 62.94% <100%> (ø) ⬆️
cmd/dfdaemon/app/root.go 63.29% <0%> (-3.38%) ⬇️
supernode/daemon/mgr/scheduler/manager.go 22.6% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3ca58...99626a4. Read the comment docs.

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit d9b3ac0 into dragonflyoss:master Sep 27, 2019
starnop pushed a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
bugfix: reduce error logs when download home dir not exist
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
bugfix: reduce error logs when download home dir not exist
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
areas/log kind/bug This is bug report for project size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants