Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

docs:add FAQ.md abot how dfget connect to supernodes in mul-supernode mode #954

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

yunfeiyanggzq
Copy link
Member

Signed-off-by: yunfeiyangbuaa [email protected]

Ⅰ. Describe what this PR did

too many questions about this in dingding group

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@starnop
Copy link
Contributor

starnop commented Sep 23, 2019

too many questions about this in dingding group

Good job. Could you please sort out a list of questions and open an issue to record that? THX.

@codecov-io
Copy link

codecov-io commented Sep 23, 2019

Codecov Report

Merging #954 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
+ Coverage   46.42%   46.43%   +0.01%     
==========================================
  Files         116      116              
  Lines        6908     6908              
==========================================
+ Hits         3207     3208       +1     
  Misses       3443     3443              
+ Partials      258      257       -1
Impacted Files Coverage Δ
supernode/daemon/mgr/scheduler/manager.go 22.6% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d3a6d5...db32623. Read the comment docs.

@yunfeiyanggzq
Copy link
Member Author

too many questions about this in dingding group

Good job. Could you please sort out a list of questions and open an issue to record that? THX.

ok

Signed-off-by: yunfeiyangbuaa <[email protected]>
@yunfeiyanggzq
Copy link
Member Author

@starnop please review it again

@starnop
Copy link
Contributor

starnop commented Sep 30, 2019

Good job. LGTM.

@starnop starnop merged commit 4b2a254 into dragonflyoss:master Sep 30, 2019
@starnop
Copy link
Contributor

starnop commented Sep 30, 2019

too many questions about this in dingding group

Good job. Could you please sort out a list of questions and open an issue to record that? THX.

@yunfeiyanggzq And please don't forget to open an issue to trace it. THX. 😄

starnop added a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
docs:add FAQ.md abot how dfget connect to supernodes in mul-supernode mode
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
docs:add FAQ.md abot how dfget connect to supernodes in mul-supernode mode
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants