This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
bugfix: paas registry mirror tls config into dfget config. #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
==========================================
+ Coverage 46.45% 46.74% +0.28%
==========================================
Files 114 114
Lines 6737 6745 +8
==========================================
+ Hits 3130 3153 +23
+ Misses 3351 3336 -15
Partials 256 256
Continue to review full report at Codecov.
|
zcc35357949
force-pushed
the
mirror_dfgetconfig
branch
from
b13eb92 to
ee143b2
Compare
|
Could you please add an integration test for this case? THX. |
zcc35357949
force-pushed
the
mirror_dfgetconfig
branch
from
ee143b2 to
79a4caf
Compare
Ok, I have added a test to validate dfgetConfig. |
|
LGTM. |
|
Could you please rebase your code and push it again? THX. |
Signed-off-by: zhouchencheng <[email protected]>
zcc35357949
force-pushed
the
mirror_dfgetconfig
branch
from
79a4caf to
d037f31
Compare
I have rebased the code. |
starnop
added a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
bugfix: paas registry mirror tls config into dfget config.
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
bugfix: paas registry mirror tls config into dfget config.
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouchencheng [email protected]
Ⅰ. Describe what this PR did
The tls config in registry_mirror should save to dfget config.Otherwise, it doesn't work.
Ⅱ. Does this pull request fix one issue?
#928
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews