Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

cleanup some unused dfget config fields #841

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

yeya24
Copy link
Collaborator

@yeya24 yeya24 commented Aug 20, 2019

Signed-off-by: yeya24 [email protected]

Ⅰ. Describe what this PR did

Dfget config field help and version is unused now, so remove them.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@yeya24 yeya24 added the chore everything about maintenance or others label Aug 20, 2019
@yeya24 yeya24 changed the title cleanup some useless dfget config fields cleanup some unused dfget config fields Aug 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #841 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   39.63%   39.62%   -0.02%     
==========================================
  Files         109      109              
  Lines        6433     6433              
==========================================
- Hits         2550     2549       -1     
  Misses       3675     3675              
- Partials      208      209       +1
Impacted Files Coverage Δ
dfget/config/config.go 91.76% <ø> (ø) ⬆️
supernode/daemon/mgr/scheduler/manager.go 24.06% <0%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017c312...28ce102. Read the comment docs.

@yeya24
Copy link
Collaborator Author

yeya24 commented Aug 20, 2019

PTAL @starnop @lowzj

@starnop
Copy link
Contributor

starnop commented Aug 20, 2019

LGTM.

@starnop starnop merged commit ad17063 into dragonflyoss:master Aug 20, 2019
@yeya24 yeya24 deleted the cleanup-dfget-fields branch August 30, 2019 15:19
starnop added a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore everything about maintenance or others size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants