Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Update indentation of comments #816

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Update indentation of comments #816

merged 1 commit into from
Aug 15, 2019

Conversation

xichengliudui
Copy link
Contributor

Ⅰ. Describe what this PR did

Update indentation of comments, for ocd, especially awkward!

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Dragonfly, @xichengliudui
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

codecov-io commented Aug 14, 2019

Codecov Report

Merging #816 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
+ Coverage   39.39%   39.41%   +0.01%     
==========================================
  Files         109      109              
  Lines        6341     6341              
==========================================
+ Hits         2498     2499       +1     
  Misses       3634     3634              
+ Partials      209      208       -1
Impacted Files Coverage Δ
supernode/daemon/mgr/scheduler/manager.go 24.81% <0%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13322ca...29dce41. Read the comment docs.

Signed-off-by: xichengliudui <[email protected]>
@allencloud
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Aug 15, 2019
@allencloud allencloud merged commit 8b2e6d2 into dragonflyoss:master Aug 15, 2019
starnop pushed a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants