This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
http_util.go: fix word in error message #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
reviewed
Aug 12, 2019
| @@ -310,7 +310,7 @@ func GetRangeSE(rangeHTTPHeader string, length int64) ([]*RangeStruct, error) { | |||
| if strings.ContainsAny(rangeHTTPHeader, "=") { | |||
| rangeSlice := strings.Split(rangeHTTPHeader, "=") | |||
| if len(rangeSlice) != 2 { | |||
| return nil, errors.Wrapf(errortypes.ErrInvalidValue, "invaild range: %s, should be like bytes=0-1023", rangeStr) | |||
There was a problem hiding this comment.
I found that there are two places in this file, which has the same incorrect spelling.
Could you help to fix that in this single pull request? @ethan-daocloud
There was a problem hiding this comment.
sure, I will find and fix that.
There was a problem hiding this comment.
@allencloud
And I check this file thoroughly, find one more , please confirm :)
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
- Coverage 39.46% 39.45% -0.02%
==========================================
Files 108 108
Lines 6294 6294
==========================================
- Hits 2484 2483 -1
Misses 3605 3605
- Partials 205 206 +1
Continue to review full report at Codecov.
|
cleanup:fix words typo in http_util.go Signed-off-by: Guangming Wang <[email protected]>
|
LGTM |
pouchrobot
added
the
LGTM
starnop
pushed a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
http_util.go: fix word in error message
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
http_util.go: fix word in error message
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
* refactor: scheduler evaluator Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guangming Wang [email protected]
Ⅰ. Describe what this PR did
fix typos
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
yes.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews