This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
[docs]supernode file ha design doc #766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeiyanggzq
force-pushed
the
modify_dfget
branch
2 times, most recently
from
16a0a45 to
f43bd2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
- Coverage 39.66% 39.64% -0.02%
==========================================
Files 109 109
Lines 6429 6429
==========================================
- Hits 2550 2549 -1
Misses 3671 3671
- Partials 208 209 +1
Continue to review full report at Codecov.
|
yunfeiyanggzq
changed the title
pouchrobot
added
areas/log
conflict/needs-rebase
and removed
conflict/needs-rebase
labels
yunfeiyanggzq
changed the title
yunfeiyanggzq
force-pushed
the
modify_dfget
branch
from
f43bd2d to
3061554
Compare
yunfeiyanggzq
force-pushed
the
modify_dfget
branch
from
c820a22 to
1a32ee6
Compare
Signed-off-by: yunfeiyangbuaa <[email protected]>
yunfeiyanggzq
force-pushed
the
modify_dfget
branch
from
98dfcf3 to
7e0faa3
Compare
|
Could we add a HA architecture picture for this? I think a picture could express more data that just code and words. WDYT? @yunfeiyangbuaa |
|
jyizheng
reviewed
Nov 4, 2019
|
|
||
| ## Tool Introduction | ||
|
|
||
| We can use distributed key-value store system such as etcd,zookeeper,consul and so on to manager the supernodes cluster.of course you can implement your own function to get supernodes information. |
There was a problem hiding this comment.
of course -> Of course,
now -> Now
jyizheng
reviewed
Nov 4, 2019
|
|
||
| - Every supernode is stand-alone,so supernode can't communicate with each other for a better schedule.For example,pieces of a task are in different p2p network,so a supernode can only schedule its plan with its own peer instead of other peer which has pieces of a task in other p2p network. | ||
|
|
||
| - Every supernode will download the same file repeatedly,which makes download slowly and a waste of disk place.This will be obvious when the supernode's num is large. |
There was a problem hiding this comment.
"makes download slowly and a waste of disk place" -> makes download slow and wastes disk space.
"the supernode's num" -> the number of supernodes
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
* feat: add lint errcheck and fix errcheck Signed-off-by: Gaius <[email protected]> * replace assert to require Signed-off-by: 孙伟鹏 <[email protected]> Co-authored-by: 孙伟鹏 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
this pr is a branch of #758 and should be marged after it
I modify the supernodeAPI and dfget.Now the supernode ha is done,supernode can be ha.but there some bugs needed to be fixed,and design tests to tests ha. I will work on it
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews