fix initiliazed => initialized #762
Conversation
|
We found this is your first time to contribute to Dragonfly, @BingGuanqi |
|
Thanks for your contribution. Could you sign off your commit please? You can check here. |
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
==========================================
+ Coverage 46.55% 46.56% +0.01%
==========================================
Files 113 113
Lines 6352 6352
==========================================
+ Hits 2957 2958 +1
Misses 3156 3156
+ Partials 239 238 -1
Continue to review full report at Codecov.
|
| @@ -52,7 +52,7 @@ func StartPeerServerProcess(cfg *config.Config) (port int, err error) { | |||
| if defaultExecutor != nil { | |||
| return defaultExecutor.StartPeerServerProcess(cfg) | |||
| } | |||
| return 0, fmt.Errorf("executor of peer server isn't be initiliazed") | |||
| return 0, fmt.Errorf("executor of peer server isn't be initialized") | |||
There was a problem hiding this comment.
executor of peer server hasn't been initialized may be better,WDYT？
There was a problem hiding this comment.
I do think so. Could you help to fix that? @BingGuanqi
There was a problem hiding this comment.
sure. I have already fixed that
fix initiliazed => initialized Signed-off-by: BingGuanqi <[email protected]>
|
LGTM. |
fix initiliazed => initialized
fix initiliazed => initialized
* fix: back source weight Signed-off-by: Gaius <[email protected]>
fix initiliazed => initialized
Signed-off-by: Guanqi Bing [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews