This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
feature:Use etcd to manager supernode ha cluster(HA first part) #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeiyanggzq
force-pushed
the
switch
branch
5 times, most recently
from
2b47ca2 to
65b0fdb
Compare
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
- Coverage 39.64% 39.57% -0.08%
==========================================
Files 109 109
Lines 6432 6459 +27
==========================================
+ Hits 2550 2556 +6
- Misses 3674 3692 +18
- Partials 208 211 +3
Continue to review full report at Codecov.
|
yunfeiyanggzq
force-pushed
the
switch
branch
3 times, most recently
from
a42664a to
3a94b63
Compare
yunfeiyanggzq
changed the title
yunfeiyanggzq
force-pushed
the
switch
branch
4 times, most recently
from
3e1c2c4 to
2cf0ec8
Compare
starnop
reviewed
Jul 25, 2019
|
Could you please add a simple usage document? THX. |
starnop
reviewed
Jul 25, 2019
starnop
reviewed
Jul 25, 2019
|
In addition, we should follow the following conventions when recording a log:
|
yunfeiyanggzq
force-pushed
the
switch
branch
2 times, most recently
from
f00a01a to
0b3e60e
Compare
yunfeiyanggzq
commented
Jul 26, 2019
yunfeiyanggzq
force-pushed
the
switch
branch
2 times, most recently
from
05bdafc to
5479f3b
Compare
|
@yunfeiyanggzq how about implement supernode manager and supernode locator with etcd ? |
|
ping @yunfeiyanggzq |
👍 also cc/ @lowzj |
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
* feat: add manager client list scheduler interface Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yunfeiyangbuaa [email protected]
Ⅰ. Describe what this PR did
to implement supernode ha,we use etcd to manager supernode ha cluster,every supernode should connects etcd and send suopernode information to etcd.other supernode will gets this information from etcd.supernode's on and off will be notified to other supernode.supernode will register a supernode peer when it find a new supernode is on in this cluster
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
my pr will be submitted as follows