Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

docs:add a question and answer about the log's time #666

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

yunfeiyanggzq
Copy link
Member

Signed-off-by: yunfeiyangbuaa [email protected]

Ⅰ. Describe what this PR did

add a question and answer about the log's time

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added areas/docs areas/log kind/question all questions or confusion about this project size/XS labels Jul 10, 2019
FAQ.md Outdated
## Why the time in the log is wrong

If you are in China,docker container uses UTC time(Coordinated Universal Time) and the host uses CST time(China Shanghai Time).So the log's time is 8 hours behind the host time.If you want to make their time consistent,
you should add a config `-v /etc/localtime:/etc/localtime:ro` before you start a container.For example,you can run this command `docker run -d --name dfclient -v /etc/localtime:/etc/localtime:ro -p 65001:65001 dragonflyoss/dfclient:0.4.0 --registry https://index.docker.io` to start a dfclient.
Copy link
Contributor

@starnop starnop Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something wrong with the sentence break?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starnop I have modified.

@codecov-io
Copy link

codecov-io commented Jul 10, 2019

Codecov Report

Merging #666 into master will decrease coverage by 2.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #666     +/-   ##
=========================================
- Coverage   48.23%   46.13%   -2.1%     
=========================================
  Files          99       99             
  Lines        5896     5893      -3     
=========================================
- Hits         2844     2719    -125     
- Misses       2827     2949    +122     
  Partials      225      225
Impacted Files Coverage Δ
dfdaemon/config/config.go 0% <0%> (-100%) ⬇️
cmd/dfget/app/root.go 62.09% <0%> (-0.18%) ⬇️
dfget/config/config.go 91.66% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33074e...a443cde. Read the comment docs.

@yunfeiyanggzq yunfeiyanggzq force-pushed the FAQ branch 2 times, most recently from 6645b62 to c61d073 Compare July 10, 2019 11:06
@starnop
Copy link
Contributor

starnop commented Jul 11, 2019

LGTM.

@starnop starnop merged commit c9728c1 into dragonflyoss:master Jul 11, 2019
starnop added a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
docs:add a question and answer about the log's time
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
docs:add a question and answer about the log's time
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
areas/docs areas/log kind/question all questions or confusion about this project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants