Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

fix format #1412

Merged
merged 1 commit into from
Jul 6, 2020
Merged

fix format #1412

merged 1 commit into from
Jul 6, 2020

Conversation

YesterdayxD
Copy link
Contributor

Ⅰ. Describe what this PR did

fix markdown format and make it read easier

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @YesterdayxD
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

@YesterdayxD Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Dragonfly, @YesterdayxD
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-commenter
Copy link

Codecov Report

Merging #1412 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1412   +/-   ##
=======================================
  Coverage   52.52%   52.52%           
=======================================
  Files         138      138           
  Lines        9185     9185           
=======================================
  Hits         4824     4824           
  Misses       3975     3975           
  Partials      386      386           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88cb000...c3c4caf. Read the comment docs.

@allencloud
Copy link
Contributor

It will LGTM until you sign your commits. @YesterdayxD

@YesterdayxD
Copy link
Contributor Author

It will LGTM until you sign your commits. @YesterdayxD

I got it.

Signed-off-by: YesterdayxD <[email protected]>
@YesterdayxD
Copy link
Contributor Author

rerun test

@allencloud
Copy link
Contributor

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jul 6, 2020
@allencloud allencloud merged commit 68b07f6 into dragonflyoss:master Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants