Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

fix: remove default registry definition in Dockerfile. #1385

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

Komey
Copy link
Contributor

@Komey Komey commented Jun 8, 2020

Ⅰ. Describe what this PR did

fix: remove default registry definition in Dockerfile.
fix: change dfpath default value in dfdaemon config template.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

  1. CLI的参数优先级大于配置文件的,官方镜像带了--registry参数, 导致使用的时候 必须手动覆盖掉
  2. 修改配置文件的文档错误

fix: change dfpath default value in dfdaemon config template.

Signed-off-by: komey <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #1385 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1385      +/-   ##
==========================================
- Coverage   51.77%   51.76%   -0.02%     
==========================================
  Files         137      137              
  Lines        9078     9078              
==========================================
- Hits         4700     4699       -1     
  Misses       3995     3995              
- Partials      383      384       +1     
Impacted Files Coverage Δ
supernode/daemon/mgr/scheduler/manager.go 21.91% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80eae52...4474dca. Read the comment docs.

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouhaibing089
Copy link
Contributor

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants