Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Fix go-lint warning: "exported method ... should have comment or be unexported" #1383

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

zouy414
Copy link
Contributor

@zouy414 zouy414 commented Jun 8, 2020

Signed-off-by: ZouYu [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #1383 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1383   +/-   ##
=======================================
  Coverage   51.22%   51.22%           
=======================================
  Files         135      135           
  Lines        8919     8919           
=======================================
  Hits         4569     4569           
  Misses       3973     3973           
  Partials      377      377           
Impacted Files Coverage Δ
dfget/locator/static_locator.go 68.49% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b4ad9...92ea5c8. Read the comment docs.

Copy link
Contributor

@zhouhaibing089 zhouhaibing089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zhouhaibing089 zhouhaibing089 merged commit d92dfcb into dragonflyoss:master Jun 9, 2020
@zouy414 zouy414 deleted the go-lint branch November 3, 2020 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants