This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
bugfix: cdn cannot re-download uncompleted task with header param #1381
+66
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
==========================================
+ Coverage 51.77% 51.83% +0.06%
==========================================
Files 137 137
Lines 9078 9088 +10
==========================================
+ Hits 4700 4711 +11
+ Misses 3995 3993 -2
- Partials 383 384 +1
Continue to review full report at Codecov.
|
The |
lowzj
force-pushed
the
fix-downloader-header
branch
from
516d62f to
5a91f96
Compare
Oh, good to know. If we're using go1.13 for compilation, then I think it is nice to align with it. Otherwise, I think we could just copy it over. |
Signed-off-by: lowzj <[email protected]>
lowzj
force-pushed
the
fix-downloader-header
branch
from
5a91f96 to
e64a762
Compare
|
LGTM. |
lowzj
added a commit
that referenced
this pull request
Jun 11, 2020
bugfix: cdn cannot re-download uncompleted task with header param backport to 1.0.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lowzj [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes: #1380
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews