This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
optimize the HTTPWithHeaders #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangforthinker
changed the title
lowzj
reviewed
May 18, 2020
pkg/httputils/http_util.go
Outdated
| @@ -52,6 +54,11 @@ const ( | |||
| DefaultTimeout = 500 * time.Millisecond | |||
| ) | |||
|
|
|||
| var ( | |||
| defaultBuiltInTransport *http.Transport | |||
| defaultBuiltInHTTPClient *http.Client | |||
There was a problem hiding this comment.
IMOP, it's better to expose them for other packages to customized them.
…ort and add timeout in request context to share the http client. Signed-off-by: allen.wq <[email protected]>
wangforthinker
force-pushed
the
feat/optimize-HTTPWithHeaders
branch
from
a8fe091 to
edaaa3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
+ Coverage 51.34% 51.55% +0.21%
==========================================
Files 130 130
Lines 8578 8612 +34
==========================================
+ Hits 4404 4440 +36
+ Misses 3806 3804 -2
Partials 368 368
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ort and add timeout in request context to share the http client.
Signed-off-by: allen.wq [email protected]
Ⅰ. Describe what this PR did
Optimize the HTTPWithHeaders. When do a http request, share the transport and add timeout in request context to share the http client.
In the early version, if we do a request with HTTPWithHeaders, new transport will be generated every request, which cases a lot of goroutines for cached conn in transport.
In my unit test, it causes error:
Ⅱ. Does this pull request fix one issue?
NONE.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Add ut.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews