Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Added 2 fuzzers #1338

Closed
wants to merge 1 commit into from
Closed

Added 2 fuzzers #1338

wants to merge 1 commit into from

Conversation

AdamKorcz
Copy link
Contributor

I am bringing the 2 fuzzers from #865 back into the upstream repository.

As agreed with @lowzj we are applying to run the fuzzers on oss-fuzz. I have setup an integration application here. To complete that application, we need the 2 fuzzers merged here on the upstream repo.

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @AdamKorcz
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Dragonfly, @AdamKorcz
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot pouchrobot added size/M and removed size/S labels May 11, 2020
lowzj
lowzj reviewed May 12, 2020
View reviewed changes
Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the gofmt checks

dfget/core/uploader/uploader_fuzz.go:17: File is not `gofmt`-ed with `-s` (gofmt)
supernode/daemon/mgr/cdn/cdn_fuzz.go:17: File is not `gofmt`-ed with `-s` (gofmt)

dfget/core/uploader/uploader_fuzz.go Outdated
@@ -0,0 +1,27 @@
/*
* Copyright 1999-2017 Alibaba Group..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Copyright The Dragonfly Authors.

@lowzj
Copy link
Member

lowzj commented May 12, 2020

Could you merge yours commits into one and sign off it?

@lowzj
Copy link
Member

lowzj commented May 12, 2020

@AdamKorcz could I close the #865 if this pull request get merged

@AdamKorcz
Copy link
Contributor Author

@lowzj This PR does not solve or replace #865, it adds just the fuzzers from that PR.

@lowzj
Copy link
Member

lowzj commented May 13, 2020

could you rebase the code and combine your 5 commits into one commit ?

@AdamKorcz
Added 2 fuzzers
da3f4cc 
Signed-off-by: Adam Korczynski <[email protected]>

Added license header

Signed-off-by: Adam Korczynski <[email protected]>

gofmt'd the fuzzers

Signed-off-by: Adam Korczynski <[email protected]>

Updated license headers

Signed-off-by: Adam Korczynski <[email protected]>

Removed year from license header

Signed-off-by: Adam Korczynski <[email protected]>
@AdamKorcz
Copy link
Contributor Author

@lowzj Let me know if it looks better now.

lowzj added a commit to lowzj/Dragonfly that referenced this pull request May 13, 2020
@lowzj
Merge pull request dragonflyoss#1338 from AdamKorcz/master
8a1b37a 
Added 2 fuzzers to setup an integration application here:
google/oss-fuzz#3790
@lowzj
Copy link
Member

lowzj commented May 13, 2020

merged via manually, closed.

@lowzj lowzj closed this May 13, 2020
@lowzj lowzj added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lowzj lowzj lowzj left review comments

Assignees
No one assigned
Labels
LGTM one maintainer or community participant agrees to merge the pull reuqest. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamKorcz @pouchrobot @lowzj